Add quit_if_one_screen for dynamic paging with explicit end-of-output signalling#1
Open
Copilot wants to merge 3 commits into
Open
Add quit_if_one_screen for dynamic paging with explicit end-of-output signalling#1Copilot wants to merge 3 commits into
quit_if_one_screen for dynamic paging with explicit end-of-output signalling#1Copilot wants to merge 3 commits into
Conversation
Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com> Agent-Logs-Url: https://github.com/forkeith/minus/sessions/4a0e60ce-db58-455e-b6b1-815f7f4b411b
Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com> Agent-Logs-Url: https://github.com/forkeith/minus/sessions/8db94332-4c4f-4f84-9bda-7746f8a59750
Copilot
AI
changed the title
Implementing auto-quit functionality for dynamic paging
Add Mar 23, 2026
quit_if_one_screen for dynamic paging with explicit end-of-output signalling
|
@copilot I see some lint issues in CI, unrelated to our changes but might make the maintainers not be able to merge... Let's try fixing them. cargo clippy --features=dynamic_output,search --tests --examples -- -D warnings |
Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com> Agent-Logs-Url: https://github.com/forkeith/minus/sessions/82e3065c-4b6e-4bcc-bce1-d43c6658b9da
Author
Fixed in 0f69549. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AliveGuard/CheckQuitIfOneScreenmechanismPager::end_of_output()method (gated ondynamic_output) that sendsCommand::CheckQuitIfOneScreendirectlyset_quit_if_one_screendocs to describe both the explicit (end_of_output) and implicit (drop) signalling mechanismsemit_events::set_quit_if_one_screenandemit_events::end_of_outputunit testsclippy::format_collectlint incheck_quit_if_one_screen_noop_when_overflowtest (replacemap(|i| format!(...)).collect::<String>()withfold+writeln!)--features=dynamic_output,search --tests --examples -- -D warnings📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.