Remove AliveGuard from dynamic paging quit-if-one-screen#2
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
Agent-Logs-Url: https://github.com/forkeith/minus/sessions/6ad07131-4482-4d7e-83e6-fd6ab6ec33a4 Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
keith-hall
April 19, 2026 18:16
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
quit_if_one_screenauto-exit in dynamic paging was triggered by two mechanisms: an explicitend_of_output()call and an implicit drop-based signal viaAliveGuard. The implicit path added complexity and a subtle ref-count dance indynamic_paging. Drop the implicit mechanism entirely;end_of_output()is the sole signal.Changes
src/pager.rs— RemoveAliveGuardstruct, itsDropimpl, and thealive: Arc<AliveGuard>field fromPager. SimplifyCloneandnew(). Updateset_quit_if_one_screendocs to document onlyend_of_output()as the end-of-stream signal.src/dynamic_pager.rs— Remove the workaroundpager_for_initconstruction (which existed solely to hold an independentAliveGuardArc).dynamic_pagingnow passes the pager directly toinit_core.Before
After