Use ONIG_OPTION_FIND_NOT_EMPTY for None-operation match patterns to fix syntest failures#1
Draft
Copilot wants to merge 2 commits into
Draft
Use ONIG_OPTION_FIND_NOT_EMPTY for None-operation match patterns to fix syntest failures#1Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/forkeith/syntect/sessions/d70e3322-55e1-4e9e-8729-33764466ce96 Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
keith-hall
April 4, 2026 09:47
View session
|
Looks like we need to update the documented public api in order to get tests to pass on CI @copilot. Also if we did fix the syntest assertion failures, we will need to update the known failures file too, please see the github actions workflow to see what commands to run to check with |
…lures Agent-Logs-Url: https://github.com/forkeith/syntect/sessions/00d31603-18b2-499d-ae07-3c2ad4e52d3a Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com>
Author
Fixed in 95ac654:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow_empty: boolparameter toRegex::search()and implement FIND_NOT_EMPTY support for None-operation patternstests/snapshots/public-api.txt) to reflect newsearch()signaturecargo fmtto fix formatting issues inregex.rsandyaml_load.rstestdata/known_syntest_failures.txt(Oniguruma) — all 3 failures (C#, LaTeX, Makefile) expected to be resolvedtestdata/known_syntest_failures_fancy.txt(fancy-regex) — C# and LaTeX failures expected resolved; Markdown remains