project: Add CRLF regex search integration test#1
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/forkeith/zed/sessions/368f2b32-2b37-4960-85e6-2f7aeb5003bb Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/forkeith/zed/sessions/9dccafe2-b436-48c2-893b-760fb1c97827 Co-authored-by: keith-hall <11882719+keith-hall@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
keith-hall
May 1, 2026 17:54
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.crlf(true)RegexBuilderoption (added alongside the fancy-regex 0.18.0 bump) makes^/$anchors in multiline mode match before\r\npairs, not just bare\n. Without it, patterns using$anchors silently fail to match in CRLF files.Important nuance uncovered during testing:
.crlf(true)in fancy-regex only affects^/$anchors and.— it does not make\nin a pattern match\r\n. Cross-line patterns targeting CRLF files should use\r?\nto handle both endings.Changes
test_multiline_regex_crlftocrates/project/tests/integration/search.rs, covering the pattern^hello$\r?\nagainst CRLF text. The$+.crlf(true)anchors correctly before\r\n; without CRLF mode the\rprevents$from firing and the pattern never matches.use language::Bufferimport from inside each test function to file-level.Self-Review Checklist:
Release Notes: