fix: use the requests content-type for request signing#92
Merged
Conversation
mlornac
previously approved these changes
May 26, 2026
| req.Body = ioutil.NopCloser(bytes.NewBuffer(body)) | ||
| req.Header.Set("Content-Type", ReqMimeType) | ||
| req.Body = io.NopCloser(bytes.NewBuffer(body)) | ||
| req.ContentLength = contentLength |
There was a problem hiding this comment.
Just wondering if it's actually required to compute the content length manually? It seems like something that should be handled by net/http internally?
Contributor
Author
There was a problem hiding this comment.
net/http should normally have this right already. I kept the assignment because the signer reads and rebuilds the body before generating the signature, so using the buffered body length felt like the safest way to keep the signed content-length in sync with the exact bytes being replayed. Happy to drop it if that feels too defensive.
ae99410 to
2f4d32e
Compare
mlornac
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Request signing always used
application/vnd.api+jsonandreq.ContentLength, which broke multipart and other non-JSON bodies. Sign and set headers from the actual body bytes and the request's Content-Type (defaulting when unset). Replace deprecatedioutilwithio.Proof of work