support search for table by 2276225819 · Pull Request #12 · formulahendry/vscode-mysql

2276225819 · 2017-12-26T13:04:42Z

有木有搜索图标可以用一下？现在的图标不太合适【】

formulahendry · 2017-12-31T06:13:07Z

package.json

+            {
+                "command": "mysql.searchTable",
+                "title": "Search Table",
+                "icon": {


Where do you use the icon?

formulahendry · 2017-12-31T06:17:38Z

package.json

                "category": "MySQL"
            },
+            {
+                "command": "mysql.searchTable",


The function is more like filter not search

formulahendry · 2017-12-31T06:18:33Z

src/common/global.ts

    }

+    public static tableFilter(tables: any[]) {
+        if ( Global.keyword ) {


The filter should only take place on a certain database not global.

formulahendry · 2017-12-31T06:18:53Z

src/mysqlTreeDataProvider.ts


+    public async searchTable() {
+        Global.keyword = await vscode.window.showInputBox({ prompt: "" , placeHolder: "table", value: Global.keyword });
+        this.refresh();


refresh should only take place on a certain database not global.

formulahendry

Please also rebase with the master branch

formulahendry · 2018-01-05T07:31:30Z

package.json

+            },
+            {
+                "command": "mysql.keywordFilter",
+                "title": "Keyword Filter",


Better naming? Just call it Filter?

formulahendry · 2018-01-05T07:33:05Z

package.json

                    "group": "mysql@1"
+                },
+                {
+                    "command": "mysql.keywordFilter",


Put this after mysql.deleteConnection

formulahendry · 2018-01-05T07:33:17Z

package.json

+                {
+                    "command": "mysql.keywordFilter",
+                    "when": "view == mysql && viewItem == connection",
+                    "group": "mysql@2"


Should be mysql@2?

formulahendry · 2018-01-05T07:33:49Z

package.json

+                    "group": "mysql@2"
+                },
+                {
+                    "command": "mysql.keywordFilter",


Put it after

{ "command": "mysql.refresh", "when": "view == mysql && viewItem == database", "group": "mysql@1" }

formulahendry · 2018-01-05T07:35:22Z

src/model/connectionNode.ts

 import { INode } from "./INode";

 export class ConnectionNode implements INode {
+    public keyword;


Leave a blank line after this

formulahendry · 2018-01-05T07:35:26Z

src/model/databaseNode.ts

 import { TableNode } from "./tableNode";

 export class DatabaseNode implements INode {
+    public keyword;


Leave a blank line after this

formulahendry · 2018-01-05T07:37:55Z

src/model/connectionNode.ts


        return Utility.queryPromise<any[]>(connection, "SHOW DATABASES")
            .then((databases) => {
+                if ( this.keyword ) {


No extra space inside parentheses

formulahendry · 2018-01-05T07:38:12Z

src/model/connectionNode.ts

            .then((databases) => {
+                if ( this.keyword ) {
+                    databases = databases.filter((table) => {
+                        return table.Database.indexOf( this.keyword ) !== -1;


Same here: No extra space inside parentheses

formulahendry · 2018-01-05T07:42:26Z

src/mysqlTreeDataProvider.ts

+    public async keywordFilter(node: DatabaseNode | ConnectionNode) {
+        vscode.window.showInputBox({
+           prompt: "" , placeHolder: "keyword", value: node.keyword,
+           validateInput: (keyword: string) => {


It this by design? It will trigger this.refresh(node) every time user input or delete a character. For the better practice, it should be only trigger when user press Enter

formulahendry · 2018-01-05T07:44:31Z

src/model/connectionNode.ts

        return Utility.queryPromise<any[]>(connection, "SHOW DATABASES")
            .then((databases) => {
+                if ( this.keyword ) {
+                    databases = databases.filter((table) => {


table -> database

formulahendry · 2018-01-05T07:47:57Z

src/model/databaseNode.ts

@@ -36,6 +38,11 @@ export class DatabaseNode implements INode {

        return Utility.queryPromise<any[]>(connection, `SELECT TABLE_NAME FROM information_schema.TABLES  WHERE TABLE_SCHEMA = '${this.database}' LIMIT ${Utility.maxTableCount}`)


If this.keyword is set, how about updating the SQL to add TABLE_NAME like '%this.keyword%'? In case there are over thousands of tables in a database.

formulahendry · 2018-01-27T10:01:05Z

src/model/databaseNode.ts

        });
-
-        return Utility.queryPromise<any[]>(connection, `SELECT TABLE_NAME FROM information_schema.TABLES  WHERE TABLE_SCHEMA = '${this.database}' LIMIT ${Utility.maxTableCount}`)
+        const filter = this.keyword ? `TABLE_NAME LIKE '%${this.keyword}%'` : "";


formulahendry · 2018-01-27T10:09:45Z

src/model/connectionNode.ts

        });

-        return Utility.queryPromise<any[]>(connection, "SHOW DATABASES")
+        return Utility.queryPromise<any[]>(connection, "SHOW DATABASES" + (this.keyword ? ` LIKE '%${this.keyword}%'` : ""))


Database name becomes blank:

formulahendry

Please also resolve https://github.com/formulahendry/vscode-mysql/pull/12/files#r159821601

2276225819 added 2 commits December 26, 2017 20:57

support search for table

d3006b4

update global.ts

07a1112

formulahendry reviewed Dec 31, 2017

View reviewed changes

formulahendry requested changes Dec 31, 2017

View reviewed changes

2276225819 added 2 commits January 4, 2018 19:20

Merge branch 'master' of https://github.com/formulahendry/vscode-mysql

8e214cc

replace keyboard shortcuts search to keyword filter menu

3dc5143

2276225819 force-pushed the master branch from 580a2c6 to 3dc5143 Compare January 4, 2018 11:22

formulahendry reviewed Jan 5, 2018

View reviewed changes

solve some problems

9805aae

formulahendry reviewed Jan 27, 2018

View reviewed changes

formulahendry requested changes Jan 27, 2018

View reviewed changes

		@@ -36,6 +38,11 @@ export class DatabaseNode implements INode {

		return Utility.queryPromise<any[]>(connection, `SELECT TABLE_NAME FROM information_schema.TABLES WHERE TABLE_SCHEMA = '${this.database}' LIMIT ${Utility.maxTableCount}`)

Conversation

2276225819 commented Dec 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

formulahendry Dec 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

formulahendry Dec 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

formulahendry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

formulahendry left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

formulahendry Dec 31, 2017 •

edited

Loading

formulahendry Dec 31, 2017 •

edited

Loading