Skip to content

[#24] Enforce exports at bottom of file with linting#252

Open
ddhogan wants to merge 1 commit into
2.xfrom
24-exports-last
Open

[#24] Enforce exports at bottom of file with linting#252
ddhogan wants to merge 1 commit into
2.xfrom
24-exports-last

Conversation

@ddhogan

@ddhogan ddhogan commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

For: #24

@ddhogan ddhogan changed the base branch from 2.x to 2.x-RC June 5, 2026 21:40
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Too much diff to scan? Review this PR in Change Stack to start with the highest-impact changes.

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 637bd366-755b-494f-a1c4-e89bc2d1ec5f

📥 Commits

Reviewing files that changed from the base of the PR and between 5da6ab6 and 580cde8.

📒 Files selected for processing (3)
  • app/about/page.tsx
  • app/page.tsx
  • eslint.config.mjs

📝 Walkthrough

Walkthrough

This PR enforces consistent export ordering across TypeScript and JSX files. It adds the import/exports-last ESLint rule to prevent exports from appearing in the middle of a file, then refactors two page files to comply by moving their metadata exports to the end. The Home and About components themselves remain unchanged; only the export style is modified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description references the related issue but lacks detail about the actual changes made in the pull request. Consider adding a brief explanation of what was changed (e.g., added import/exports-last rule and refactored metadata exports) to make the description more informative.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: enforcing exports at the bottom of files via the import/exports-last ESLint rule.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@ddhogan ddhogan changed the base branch from 2.x-RC to 2.x June 5, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant