Skip to content

Replaced table markup with wrapper#43

Open
gorriecoe wants to merge 1 commit into
foundation:masterfrom
gorriecoe:wrapper_markup
Open

Replaced table markup with wrapper#43
gorriecoe wants to merge 1 commit into
foundation:masterfrom
gorriecoe:wrapper_markup

Conversation

@gorriecoe

Copy link
Copy Markdown

Replaced table markup with wrapper and updated the indentation so they
are consistent

Replaced table markup with wrapper and updated the indentation so they
are consistent
Comment thread src/layouts/default.html
</head>
<body>
<span class="preheader">{{description}}</span>
<wrapper class="body">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that the <center> tag is missing here along with some of the classes for centering. Do you have any tests that show the container is centering works on all email clients supported?

@DanielRuf DanielRuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the last feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants