fix: migrates deprecated gulp-uncss to postcss-uncss#73
Open
Juuldamen wants to merge 1 commit into
Open
Conversation
|
@Juuldamen May you please merge all my pull requests before applying your fix? This will eliminate any potential clash when they merge all of them. It would be great if you could also submit a pull request to my fork so that people can use it as a temp workaround. Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gulp-uncss has been deprecated and advices using the UnCSS plugin for PostCSS instead. I tried the change on some custom template files with Node 12 and saw no changes in the build artifact files. But it sounds like a good idea to also confirm this with the example templates.
The removal of
gulp-uncssalso removes the dependency onphantomjs-prebuilt. Which downloads a large binary file that seems to cause issues getting the project to build in some CI environments.The build error caused by
phantomjs-prebuiltin our GitLab CI environment.