Skip to content

fix incorrect info about custom data and fix prototype link#493

Merged
tdhartwick merged 3 commits into
foundation:developfrom
zebapy:develop
Sep 14, 2016
Merged

fix incorrect info about custom data and fix prototype link#493
tdhartwick merged 3 commits into
foundation:developfrom
zebapy:develop

Conversation

@zebapy

@zebapy zebapy commented Jun 30, 2016

Copy link
Copy Markdown
Contributor

Either the source files that have panini preconfigured need to be updated to add the data: 'src/data' path or the documentation should reflect the requirement.

Also the prototyping link was dead. I'm not sure if this is the correct new link but I've added it for now.

Edited Remade PR as requested by @rafibomb in #492

Either the source files that have panini preconfigured need to be updated to add the `data: 'src/data'` path or the documentation should reflect the requirement. 

Also the prototyping link was dead. I'm not sure if this is the correct new link but I've added it for now.
@zebapy

zebapy commented Jun 30, 2016

Copy link
Copy Markdown
Contributor Author

@rafibomb do you think the boilerplate/template should just include the src/data path to begin with?

@rafibomb

Copy link
Copy Markdown
Contributor

Good question! Let's see what @kball thinks

@kball

kball commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

@zebapy I think it would make sense to have data in there by default with a sample/empty data file there as an example.

@rafibomb

rafibomb commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

Thanks @kball
@zebapy Is that something you can add to this PR? Would love to document this better in panini!

@rafibomb rafibomb added this to the 2.2.2 milestone Jul 8, 2016
@zebapy

zebapy commented Jul 8, 2016

Copy link
Copy Markdown
Contributor Author

@rafibomb I can add that, sure. That would be done in the template project, right?

@rafibomb

Copy link
Copy Markdown
Contributor

Yes! The foundation-emails-template is what creates the project structure! Can you add it there too and the docs here can describe it.

@zebapy

zebapy commented Jul 19, 2016

Copy link
Copy Markdown
Contributor Author

@rafibomb There's a PR open for custom data. I'll update this PR to remove the doc change and leave the link fix. foundation/foundation-emails-template#20

@tdhartwick tdhartwick merged commit 0e2d442 into foundation:develop Sep 14, 2016
@tdhartwick

Copy link
Copy Markdown
Contributor

Thanks @zebapy! Merged in the updated Panini copy.

@Lulubbz

Lulubbz commented Nov 22, 2021

Copy link
Copy Markdown

Ohk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants