test(verify): cover blockscout verifier with etherscan api key set on unknown chain - #15819
Merged
mablr merged 1 commit intoJul 20, 2026
Conversation
Osraka
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
July 18, 2026 20:02
stevencartavia
approved these changes
Jul 20, 2026
mablr
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds regression coverage for the
forge verify-contractverifier routing case from #11430. The existing test covers an unknown Etherscan chain with Blockscout and--verifier-url; this adds the same path withETHERSCAN_API_KEYset so the explicit Blockscout verifier continues to avoid Etherscan API URL resolution.Solution
Extend the existing
can_validate_verifier_settingstest with the exact combination:--verifier blockscout--verifier-urlETHERSCAN_API_KEYpresent in the command environmentThe expected result remains the Blockscout already-verified flow, not
No known Etherscan API URL.Validation
cargo test -p forge --test cli can_validate_verifier_settingscargo test -p forge --test cli verify::Note:
cargo test -p forge --test verifyis not a valid target in this repo; these verify tests live under thecliintegration test target.