[#3939] Add Maximum Hit Points damage & healing type#6662
Merged
Conversation
Contributor
|
Any shot we could get some sort of "sources" of maximum hit point reduction / increase as some form of book-keeping? Maybe some sort of display in the Hit Point dialog on actor sheets? Would help to know what specific effect to end with something like Greater Restoration: |
Fyorl
requested changes
Jan 28, 2026
Contributor
Fyorl
left a comment
Fyorl
left a comment
There was a problem hiding this comment.
This looks pretty good, thank you. One minor thing that's maybe easy to look into is that the damage type labels would look nicer if they fit on one line. We already had this issue with temp hp but I only noticed it now:
If we change those labels in the damage breakdown to something like 'Max HP' and 'Temp. HP' then they will probably fit better.
Fyorl
approved these changes
Jan 28, 2026
Adds a new option to both damage and healing options that applies to the target's temporary maximum hit points. This option is responsive to what is applying it, so when used in a Heal activity it increases the maximum hit points (and current hit points by the same amount) while in any other activity it reduces the max (but doesn't modify current HP except by clamping). Closes #3939
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option to both damage and healing options that applies to the target's temporary maximum hit points. This option is responsive to what is applying it, so when used in a Heal activity it increases the maximum hit points (and current hit points by the same amount) while in any other activity it reduces the max (but doesn't modify current HP except by clamping).
Closes #3939