Allow removal of traits and prevent duplicate traits on action usage#18422
Open
nikolaj-a wants to merge 1 commit intofoundryvtt:masterfrom
Open
Allow removal of traits and prevent duplicate traits on action usage#18422nikolaj-a wants to merge 1 commit intofoundryvtt:masterfrom
nikolaj-a wants to merge 1 commit intofoundryvtt:masterfrom
Conversation
nikolaj-a
force-pushed
the
replace-action-traits
branch
from
54d58af to
2293652
Compare
Collaborator
|
I need to try what I'm doing for overrideTraits, once I do I can get back to you on this. |
nikolaj-a
force-pushed
the
replace-action-traits
branch
from
2293652 to
ece0775
Compare
nikolaj-a
force-pushed
the
replace-action-traits
branch
from
ece0775 to
4e97eeb
Compare
Collaborator
|
I posted it in the discord but here it is again for good measure: Me and stwlam talked it over and decided to try to keep the API roughly the same. In other words, keep traits to adding new traits rather than replacing. Instead override-traits would be supported to replace the traits list with a new one. You don't have to support override-traits=true though (just override-traits=fire,water,cold). Even in Sorry for the incredible delay on that |
nikolaj-a
force-pushed
the
replace-action-traits
branch
from
4e97eeb to
6c9a33a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.