Skip to content

Refactor armour and NPC sheets to use Raiment rune and update remaster changes journal page#18625

Draft
TheWeion wants to merge 1 commit intofoundryvtt:masterfrom
TheWeion:14083/remasterRaimentRune
Draft

Refactor armour and NPC sheets to use Raiment rune and update remaster changes journal page#18625
TheWeion wants to merge 1 commit intofoundryvtt:masterfrom
TheWeion:14083/remasterRaimentRune

Conversation

@TheWeion
Copy link
Copy Markdown
Contributor

Summary

Refactored all armours and NPCs sheets which used the Glamered rune to use the Raiment rune, added Raiment Rune to Remaster Changes journal page.

Closes #14083

Test Steps

Scenario 1 - Armour using the Raiment Rune

  1. Navigate to the Compendium Packs tab in the sidebar, search for an armour item which used the Glamered rune (e.g. "Prismatic Plate"), right-click the result and click on Import Entry
  2. When the armour details dialog is displayed, navigate to the Details tab, and scroll down to the Precious Materials and Runes section
  3. Observe the first Property Rune that is selected
  4. Click on the list box to expand it, and observe the list contents.

Expected Result:
Armour Items that used the Glamered rune should be replaced with the Raiment rune. Additionally, there should be no results for the Glamered rune in the Property Rune list box, as this has been replaced with the Raiment rune per the Remaster.

Scenario 2 - NPC using the Raiment Rune

  1. Navigate to the Compendium Packs tab in the sidebar, search for an NPC that used an armour item which used the Glamered rune (e.g. "Arodeth"), and click the result to open the NPC sheet
  2. When the NPC sheet is displayed, navigate to the Inventory tab, and observe the worn armour.

Expected Result:
Armour Items that used the Glamered rune should be replaced with the Raiment rune, this should be reflected in the item's name when "Specific Magic Armor" is disabled.

Scenario 2 - Remaster Changes Journal

  1. Navigate to the Settings tab in the sidebar, and click on the "Remaster Changes" button under Pathfinder Second Edition
  2. Navigate to the Equipment page, and observe the Equipment table.

Expected Result:
When the user navigates to the Equipment page on the Remaster Changes journal, a new row should be present in the table with the first column being "Glamered Rune" and the second column referencing the Raiment rune per the remaster changes.

…ich used the Glamered rune to use the Raiment rune, added Raiment Rune to Remaster Changes journal page.
@TikaelSol
Copy link
Copy Markdown
Collaborator

TikaelSol commented Mar 23, 2025

We can't remove the glamored rune without migrating existing actors in world, and we aren't running migrations until we finish data model work.

@TheWeion
Copy link
Copy Markdown
Contributor Author

We can't remove the glamored rune without migrating existing actors in world, and we aren't running migrations until we finish data model work.

Ah good point, didn't think of that. 👍

@TheWeion TheWeion marked this pull request as draft March 23, 2025 22:46
@TheWeion TheWeion changed the title Refactor Armour and NPC Sheets to Use Raiment Rune and Update Remaster Changes Journal Page If Merged, This PR Will Refactor Armour and NPC Sheets to Use Raiment Rune and Update Remaster Changes Journal Page Mar 23, 2025
@TikaelSol TikaelSol changed the title If Merged, This PR Will Refactor Armour and NPC Sheets to Use Raiment Rune and Update Remaster Changes Journal Page Refactor Armour and NPC Sheets to Use Raiment Rune and Update Remaster Changes Journal Page Mar 24, 2025
@TikaelSol TikaelSol changed the title Refactor Armour and NPC Sheets to Use Raiment Rune and Update Remaster Changes Journal Page Refactor armour and NPC sheets to use Raiment rune and update remaster changes journal page Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glamered rune still present despite getting renamed to Raiment

2 participants