Refactor armour and NPC sheets to use Raiment rune and update remaster changes journal page#18625
Draft
TheWeion wants to merge 1 commit intofoundryvtt:masterfrom
Draft
Refactor armour and NPC sheets to use Raiment rune and update remaster changes journal page#18625TheWeion wants to merge 1 commit intofoundryvtt:masterfrom
TheWeion wants to merge 1 commit intofoundryvtt:masterfrom
Conversation
…ich used the Glamered rune to use the Raiment rune, added Raiment Rune to Remaster Changes journal page.
Collaborator
|
We can't remove the glamored rune without migrating existing actors in world, and we aren't running migrations until we finish data model work. |
Contributor
Author
Ah good point, didn't think of that. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored all armours and NPCs sheets which used the Glamered rune to use the Raiment rune, added Raiment Rune to Remaster Changes journal page.
Closes #14083
Test Steps
Scenario 1 - Armour using the Raiment Rune
Expected Result:
Armour Items that used the Glamered rune should be replaced with the Raiment rune. Additionally, there should be no results for the Glamered rune in the Property Rune list box, as this has been replaced with the Raiment rune per the Remaster.
Scenario 2 - NPC using the Raiment Rune
Expected Result:
Armour Items that used the Glamered rune should be replaced with the Raiment rune, this should be reflected in the item's name when "Specific Magic Armor" is disabled.
Scenario 2 - Remaster Changes Journal
Expected Result:
When the user navigates to the Equipment page on the Remaster Changes journal, a new row should be present in the table with the first column being "Glamered Rune" and the second column referencing the Raiment rune per the remaster changes.