Update tech trait description to include all portions#21446
Update tech trait description to include all portions#21446TikaelSol merged 1 commit intofoundryvtt:v13-devfrom
Conversation
|
Not sure if we want to just dump the entire description in the trait like this, or wait until there's a way to localize them differently depending on whether it's armor, or shields, or weapons, etc? |
|
Thanks for the PR. As a note, we use imperative case for PR titles, basically completing the sentence "If merged, this PR will..." (This makes it easy to just use the PR title in the changelog). For the actual PR, just move this to the en.json file instead of the SF2e overrides. Also, make sure you check wording against the book, not AoN. |
|
@TikaelSol Thanks for the feedback and for fixing the PR title. Looking at the text in the book, there were two item types with differences. I think the AoN version reads better, but I'm happy to make the change to use the book's phrasing. I put the change in the overrides file so that the trait in pathfinder wouldn't change. Is it ok using the starfinder language for the tech trait in pathfinder worlds? |
|
The tech trait in PF is the SF tech trait, we're ignoring the two Kingmaker items with that trait (Or, rather forcibly swapping them to use SF rules). Also we can stick to the cleaner description |
Fixes foundryvtt#21357 Simple version of a fix to make sure that the tech trait in Foundry matches the official wording on Archives of Nethys. https://2e.aonsrd.com/traits/179-tech Issue mentioned showing a different description based on the item type. I'm new to contributing to Foundry so I went with the simple approach to start. Would be happy to implement this if desired. <img width="1512" height="982" alt="Screenshot 2026-02-04 at 18 37 32" src="https://github.com/user-attachments/assets/0110057f-6a3c-443c-8d90-37294d957b35" />
3db5ff8 to
13515ee
Compare
|
Appreciate the context! Moved the description into en.json ✅ |
Fixes #21357
Simple version of a fix to make sure that the tech trait in Foundry matches the official wording on Archives of Nethys.
https://2e.aonsrd.com/traits/179-tech
Issue mentioned showing a different description based on the item type. I'm new to contributing to Foundry so I went with the simple approach to start. Would be happy to implement this if desired.