Skip to content

Update tech trait description to include all portions#21446

Merged
TikaelSol merged 1 commit intofoundryvtt:v13-devfrom
steve148:sf2e/tech-trait
Feb 14, 2026
Merged

Update tech trait description to include all portions#21446
TikaelSol merged 1 commit intofoundryvtt:v13-devfrom
steve148:sf2e/tech-trait

Conversation

@steve148
Copy link
Copy Markdown
Contributor

@steve148 steve148 commented Feb 4, 2026

Fixes #21357

Simple version of a fix to make sure that the tech trait in Foundry matches the official wording on Archives of Nethys.

https://2e.aonsrd.com/traits/179-tech

Issue mentioned showing a different description based on the item type. I'm new to contributing to Foundry so I went with the simple approach to start. Would be happy to implement this if desired.

Screenshot 2026-02-04 at 18 37 32

@mechamaya
Copy link
Copy Markdown
Contributor

Not sure if we want to just dump the entire description in the trait like this, or wait until there's a way to localize them differently depending on whether it's armor, or shields, or weapons, etc?

@TikaelSol TikaelSol added pr: data update Updates to existing actors and items sf2e System issues affecting Starfinder 2e labels Feb 5, 2026
@TikaelSol TikaelSol changed the title data(sf2e): update tech trait with official wording Update tech trait description to include all portions Feb 5, 2026
@TikaelSol
Copy link
Copy Markdown
Collaborator

TikaelSol commented Feb 5, 2026

Thanks for the PR. As a note, we use imperative case for PR titles, basically completing the sentence "If merged, this PR will..." (This makes it easy to just use the PR title in the changelog).

For the actual PR, just move this to the en.json file instead of the SF2e overrides. Also, make sure you check wording against the book, not AoN.

@steve148
Copy link
Copy Markdown
Contributor Author

steve148 commented Feb 6, 2026

@TikaelSol Thanks for the feedback and for fixing the PR title.

Looking at the text in the book, there were two item types with differences. I think the AoN version reads better, but I'm happy to make the change to use the book's phrasing.

# AON
Armor with the tech trait incorporate electronics, computer systems, integrated power sources, and a comm unit.
# Book
This armor incorporates electronics, computer systems, integrated power sources, and a comm unit.

# AoN
Shields with the tech trait incorporate electronics, computer systems, and integrated power sources.
# Book
This shield incorporates electronics, computer systems, and integrated power sources.

I put the change in the overrides file so that the trait in pathfinder wouldn't change. Is it ok using the starfinder language for the tech trait in pathfinder worlds?

@TikaelSol
Copy link
Copy Markdown
Collaborator

TikaelSol commented Feb 7, 2026

The tech trait in PF is the SF tech trait, we're ignoring the two Kingmaker items with that trait (Or, rather forcibly swapping them to use SF rules). Also we can stick to the cleaner description

Fixes foundryvtt#21357

Simple version of a fix to make sure that the tech trait in Foundry
matches the official wording on Archives of Nethys.

https://2e.aonsrd.com/traits/179-tech

Issue mentioned showing a different description based on the item type.
I'm new to contributing to Foundry so I went with the simple approach to
start. Would be happy to implement this if desired.

<img width="1512" height="982" alt="Screenshot 2026-02-04 at 18 37 32" src="https://github.com/user-attachments/assets/0110057f-6a3c-443c-8d90-37294d957b35" />
@steve148
Copy link
Copy Markdown
Contributor Author

steve148 commented Feb 8, 2026

Appreciate the context! Moved the description into en.json ✅

@TikaelSol TikaelSol merged commit c54a57c into foundryvtt:v13-dev Feb 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: data update Updates to existing actors and items sf2e System issues affecting Starfinder 2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SF2e Tech Trait Description Incorrect

3 participants