Add build script for pf2e and sf2e anachronism#21467
Merged
stwlam merged 2 commits intofoundryvtt:v13-devfrom Feb 22, 2026
Merged
Add build script for pf2e and sf2e anachronism#21467stwlam merged 2 commits intofoundryvtt:v13-devfrom
stwlam merged 2 commits intofoundryvtt:v13-devfrom
Conversation
stwlam
reviewed
Feb 12, 2026
|
|
||
| interface LevelDatabaseOptions { | ||
| systemId: SystemId; | ||
| systemId?: SystemId; |
Collaborator
There was a problem hiding this comment.
Why optional now? These are much less obvious as to their purpose and could use some jsdoc
Collaborator
Author
There was a problem hiding this comment.
The property is used to load a system manifest file to then use to validate the packs, however in the case of anachronism we want to load a module manifest instead. So I added manifest as an alternative way to initialize.
We could either make the core system pass in a manifest file always instead of system (since manifest file supports all use cases) or include a packageType: "system" | "module" param. What do you prefer?
Collaborator
Author
There was a problem hiding this comment.
It now always accepts manifest instead of manifest or systemId. Let me know if this is preferable.
CarlosFdez
force-pushed
the
anachronism
branch
from
d3e0ad9 to
86ac3d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.