Skip to content

Add ISO 8601 string timestamp detection to fieldtypes #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yunzheng merged 2 commits into from
May 17, 2026
Merged

Add ISO 8601 string timestamp detection to fieldtypes #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c3d88c
Add ISO 8601 string timestamp detection to fieldtypes
JSCU-CNI May 12, 2026
0dc6ad1
Merge branch 'main' into fieldtype-string-datetime
JSCU-CNI May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flow/record/fieldtypes/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

RE_NORMALIZE_PATH = re.compile(r"[\\/]+")
RE_WINDOWS_PATH = re.compile(r"^[a-zA-Z]:[\\/]")
RE_ISO8601_DATETIME = re.compile(r"^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(\.\d{3})?(Z|[\+-]\d{2}:\d{2})$")

UTC = timezone.utc

Expand Down Expand Up @@ -112,6 +113,8 @@ def fieldtype_for_value(value: object, default: str = "string") -> str:
if isinstance(value, _bytes):
return "bytes"
if isinstance(value, str):
if RE_ISO8601_DATETIME.match(value):
return "datetime"
return "string"
if isinstance(value, _float):
return "float"
Expand Down
5 changes: 5 additions & 0 deletions tests/fieldtypes/test_fieldtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,11 @@ def test_fieldtype_for_value() -> None:
assert fieldtype_for_value(b"\r\n") == "bytes"
assert fieldtype_for_value("hello world") == "string"
assert fieldtype_for_value(datetime.now()) == "datetime" # noqa: DTZ005
assert fieldtype_for_value("2026-03-19T14:20:23+00:00") == "datetime"
assert fieldtype_for_value("2026-03-19T14:20:23-01:00") == "datetime"
assert fieldtype_for_value("2026-03-19T14:20:23Z") == "datetime"
assert fieldtype_for_value("2026-03-19T14:20:23.123Z") == "datetime"
assert fieldtype_for_value("2026-03-19T14:20:23.123+01:00") == "datetime"
assert fieldtype_for_value([1, 2, 3, 4, 5]) == "string"
assert fieldtype_for_value([1, 2, 3, 4, 5], None) is None
assert fieldtype_for_value(object(), None) is None
Expand Down
Loading