Open
Conversation
palkan
approved these changes
Aug 4, 2023
palkan
left a comment
palkan
left a comment
There was a problem hiding this comment.
Всё тут 🤘
Но пару вопросиков оставил.
| @apply cursor-pointer; | ||
| } | ||
|
|
||
| .player-playing .player-btn[data-action="click->player#play"] { |
There was a problem hiding this comment.
А че не понравилось в предыдущем варианте?)
| <% if live || !station %> | ||
| <div class="player--controls"> | ||
| <span class="player-btn" data-action="click->player#play"> | ||
| <%= button_to "#", method: :post, form: {class: "player-btn player-btn--play", data: {"turbo-command" => "PlayerCommand#resume"}} do %> |
Comment on lines
+38
to
+42
| turbo_stream.invoke( | ||
| "setAttribute", | ||
| args: ["data-player-is-playing-value", is_playing.to_s], | ||
| selector: "[data-controller='player']" | ||
| ) |
There was a problem hiding this comment.
Пожалуй, вот к этому я бы придрался — теперь локальное воспроизведение (в режиме не-радио) тоже контролируется сервером. А если учесть, что сервер на Рельсах, лаг между нажатием на кнопку и воспроизведением может быть заметен)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавить возможность автору трансляции ставить проигрывание трека на паузу (и обратно) и синхронизировать эти действия со слушателями.