Performance optimization for wildcard rules matching#217
Open
misaka10987 wants to merge 2 commits intofoxyproxy:mainfrom
Open
Performance optimization for wildcard rules matching#217misaka10987 wants to merge 2 commits intofoxyproxy:mainfrom
misaka10987 wants to merge 2 commits intofoxyproxy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimized CPU time of global exclusion wildcard rules testing by generating better regular expression.
A typical case of visiting https://www.bilibili.com/, with about 250 network requests and 27 global exclude, takes 100% cpu for 3s+ on firefox developer edition on Arch Linux and AMD 7900X. This PR fixed the issue and reduced CPU usage to less than 5% under the same case.