feat: add pdc categories to allproducts query#1332
Open
Marwaxhello wants to merge 1 commit intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Marwaxhello
force-pushed
the
fix/add-pdc-category-to-getAllProducts
branch
from
8371738 to
a5a949c
Compare
Marwaxhello
force-pushed
the
fix/add-pdc-category-to-getAllProducts
branch
from
a5a949c to
11f3c11
Compare
bddjong
requested changes
Dec 23, 2025
Contributor
bddjong
left a comment
bddjong
left a comment
There was a problem hiding this comment.
Er moeten nog wat meer wijzigingen gebeuren in de overige-objecten-api. Een request naar de API volgt in op hoog niveau een paar stappen
- Call endpoint (bv.
/objects/kennisartikel)
| - Server doet de benodigde GraphQL API calls naar Strapi (die heb je hier al aangepast)
| - Server voert aggregation of mapping stappen uit
| - Server geeft een response met de gemapte data
We hebben nu alleen stap 2 aangepast. Ik verwacht dat we het volgende nog nodig hebben:
- Update Open API schema
- Update generate/mapping code om de categories terug te geven in het juiste formaat. Ik zie bijvoorbeeld
generateKennisartikelObject.tswaar we deze nieuwe attributen misschien nog moeten toevoegen en mappen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.