Skip to content

Expand execution scaffolding and clarify terminology - #1

Merged
franksong2702 merged 1 commit into
mainfrom
agent/kb-execution-and-terminology
Jul 12, 2026
Merged

Expand execution scaffolding and clarify terminology#1
franksong2702 merged 1 commit into
mainfrom
agent/kb-execution-and-terminology

Conversation

@franksong2702

Copy link
Copy Markdown
Owner

What changed

  • add six executable textbook lab packages and an end-to-end evaluation engineering example
  • add five Agent Bible capability running-rule samples, generated JSON, compiler, and semantic checker
  • replace opaque terminology in current documentation with plain Chinese while preserving signed and historical snapshots
  • add a terminology audit and regression checker integrated into the knowledge-base health check
  • synchronize ADS generated files, navigation, governance, and repository self-description

Why

The knowledge base had strong conceptual coverage but needed more executable scaffolding and clearer reader-facing language. It also needed mechanical protection against terminology drift and generated-file divergence.

Validation

  • python3 _tools/check_plain_language_terms.py
  • python3 _tools/compile_decision_system.py --check
  • python3 _tools/compile_agent_contracts.py --check
  • python3 _tools/check_agent_contracts.py
  • python3 _tools/check_ads_case_crossrefs.py
  • python3 _tools/kb_health_check.py
  • git diff --cached --check

All checks passed locally.

@franksong2702

Copy link
Copy Markdown
Owner Author

Owner review: approved for merge

Scope check: clean. The diff matches the PR description: executable teaching scaffolding, Agent Bible running rules and generated JSON, terminology cleanup, and regression tooling.

Critical review: no blocking findings. The Python tools use argument-array subprocess calls; no shell=True, eval, exec, credential material, database writes, or untrusted LLM output execution was introduced.

Independent verification:

  • extracted the reference code from all six textbook labs plus the Evaluation engineering sample into temporary directories
  • 30 unit tests passed across Labs 02/07/09/10/12 and the Evaluation bundle
  • Lab 05 local mock pipeline passed first-run counts and second-run checkpoint/idempotency checks
  • ADS compiler: 76 entries, strict validation and generated YAML sync passed
  • Agent rules: 5 contracts, 50 case definitions, 5 trace samples passed
  • terminology guard: 0 current-document violations
  • full knowledge-base health check passed; broken/ambiguous links: 0
  • GitHub Actions KB Health Check passed

No blocking review findings. Safe to merge.

@franksong2702
franksong2702 marked this pull request as ready for review July 12, 2026 13:09
@franksong2702
franksong2702 merged commit 8978b49 into main Jul 12, 2026
1 check passed
@franksong2702
franksong2702 deleted the agent/kb-execution-and-terminology branch July 12, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant