Conversation
Migrates the GO subgraph BFS endpoint into the service:
- ``get_go_subgraph_data(session, snapshot_id, go_ids, depth)``
parses the comma-separated GO ids, resolves seed terms, then
walks ``GOTermRelationship`` upward up to ``depth`` levels.
Returns ``{"nodes": [...], "edges": [...]}`` with ``is_query``
flagged on the seed terms. Raises ``EntityNotFoundError`` when
the OntologySnapshot does not resolve.
- Router endpoint reduces from ~70 LOC body to a 6-LOC shim.
The ``GOTermRelationship`` import was lifted into the service
(local within the function); the router no longer needs to import
the relationship ORM. Removes the now-unused ``GOTermRelationship``
import from the router via ruff's auto-fix.
Sizes: annotations router 683 → 617 LOC. Local-first verified:
ruff + flake8 + mypy clean, 1160 pytest passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GO subgraph BFS endpoint moves to the service. Router 683 → 617 LOC. Local-first: ruff/flake8/mypy clean, 1160 pytest pass.