refactor(training): T-CONTEXTS partial — KnnTransferContext#80
Merged
refactor(training): T-CONTEXTS partial — KnnTransferContext#80
Conversation
Introduces ``KnnTransferContext`` frozen dataclass in ``training_dump_helpers.py`` bundling the 12 per-call data inputs (queries, references, ontology maps, optional enrichment helpers) that ``_knn_transfer_and_label`` consumes. Signature collapses 16 args → 5: ``session``, ``p``, ``ctx``, ``sequence_context`` (existing), ``stream_output`` (existing). ``session`` and payload ``p`` stay separate as configuration; the existing ``SequenceContext`` and ``StreamOutput`` helpers continue to handle their orthogonal concerns. Three call sites updated: - ``training_dump_helpers.py`` train branch (line ~1515) - ``training_dump_helpers.py`` test stream branch (line ~1747) - ``tests/test_knn_streaming_smoke.py`` shared test runner Body destructures the context once at the top so the rest of the implementation stays diff-minimal. Sizes: - training_dump_helpers.py: +35 LOC (dataclass + destructuring) - Smell baseline: 77 → 75 (params>6: 22 → 20: ``_knn_transfer_and_label`` retired plus 1 knock-on improvement) Local-first 5 verde (ruff + flake8 + pytest 1163 + check_smells).
frapercan
force-pushed
the
feat/t-contexts-knn-transfer
branch
from
355f58d to
51e481d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria (master plan §24 Fase 1 — T-CONTEXTS partial)
Fifth incremental Parameter Object slice. Tackles the remaining 16-arg offender in core training pipeline.
Changes
protea/core/training_dump_helpers.py:KnnTransferContextfrozen dataclass bundling the 12 per-call data inputs (queries, references, ontology maps, optional enrichment helpers)._knn_transfer_and_labelsignature collapses 16 args → 5 (session,p,ctx, plus existingsequence_context/stream_output).tests/test_knn_streaming_smoke.py: shared test runner updated.Smell budget
77 → 75 offenders. params>6: 22 → 20 (
_knn_transfer_and_labelretired plus 1 knock-on).Test plan
poetry run ruff check protea scriptspoetry run flake8 protea/poetry run pytest tests/ --ignore=tests/test_jobs_pg.py(1163 passed, 11 skipped)poetry run python scripts/check_smells.py(75 known, none new)T-CONTEXTS progress (5 slices total, 4 in flight pending CI)
Combined: 69 args → 15 across the 5 entry points.