This repository was archived by the owner on Jun 25, 2026. It is now read-only.
fix(screener): correct icon, restrict move/add, batch triage requests (backport #616)#617
Merged
Merged
Conversation
- getIcon: the Screener's 'eye' icon is authoritative, so a stray Mailbox Settings icon can't make it render as a generic folder - exclude the Screener (a system folder) from move/add target lists and from the Folders management list - batch Block/Allow so rapid triage no longer fires concurrent sieve rebuilds that race on the shared automation script (CannotChangeConstantError) - rename SCREENING_MAILBOX_NAME -> SCREENER_MAILBOX_NAME and mailboxIds.screening -> .screener for naming consistency Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Submit the allow and screen-out requests independently so a failure in one doesn't skip the other (a burst can mix both across different senders, all already optimistically removed). Addresses review on frappe#616. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #616 to
v0.eyeicon is now authoritative ingetIcon, so a stray Mailbox Settings icon can't make it render as a generic folder.CannotChangeConstantError).Also renames
SCREENING_MAILBOX_NAME→SCREENER_MAILBOX_NAMEandmailboxIds.screening→.screenerfor naming consistency.🤖 Generated with Claude Code