fix: use submission capability for identity#103
Merged
Conversation
Contributor
Confidence Score: 4/5The identity capability check can reject valid mail-only identity servers.
suite/mail/jmap/services/mail/identity.py
|
| Filename | Overview |
|---|---|
| suite/mail/jmap/services/mail/identity.py | Adds a submission capability requirement to the identity service, which can over-restrict identity calls. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
suite/mail/jmap/services/mail/identity.py:10-14
**Submission Capability Blocks Identity**
When a JMAP server advertises `core` and `mail` but not `submission`, every `Identity/get` or `Identity/set` call now fails local capability validation before the request is sent. Identity operations are mail-capability calls, so identity CRUD and fetch paths can raise `ValueError` on an otherwise valid server.
```suggestion
capabilities: ClassVar[list[str]] = [
"urn:ietf:params:jmap:core",
"urn:ietf:params:jmap:mail",
]
```
Reviews (1): Last reviewed commit: "fix: use `submission` capability for ide..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.