Skip to content

fix: use submission capability for identity#103

Merged
s-aga-r merged 1 commit into
frappe:developfrom
s-aga-r:fix/identity-capability
Jun 27, 2026
Merged

fix: use submission capability for identity#103
s-aga-r merged 1 commit into
frappe:developfrom
s-aga-r:fix/identity-capability

Conversation

@s-aga-r

@s-aga-r s-aga-r commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@s-aga-r s-aga-r requested a review from krantheman as a code owner June 27, 2026 19:15
@greptile-apps

greptile-apps Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The identity capability check can reject valid mail-only identity servers.

  • IdentityService now validates submission for all identity RPCs.
  • Servers with core and mail identity support but no EmailSubmission support can no longer fetch or update identities through this service.

suite/mail/jmap/services/mail/identity.py

Important Files Changed

Filename Overview
suite/mail/jmap/services/mail/identity.py Adds a submission capability requirement to the identity service, which can over-restrict identity calls.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
suite/mail/jmap/services/mail/identity.py:10-14
**Submission Capability Blocks Identity**

When a JMAP server advertises `core` and `mail` but not `submission`, every `Identity/get` or `Identity/set` call now fails local capability validation before the request is sent. Identity operations are mail-capability calls, so identity CRUD and fetch paths can raise `ValueError` on an otherwise valid server.

```suggestion
	capabilities: ClassVar[list[str]] = [
		"urn:ietf:params:jmap:core",
		"urn:ietf:params:jmap:mail",
	]
```

Reviews (1): Last reviewed commit: "fix: use `submission` capability for ide..." | Re-trigger Greptile

Comment thread suite/mail/jmap/services/mail/identity.py
@s-aga-r s-aga-r merged commit 1175586 into frappe:develop Jun 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant