Skip to content

fix(mail): sidebar background in mobile view#108

Merged
GursheenK merged 1 commit into
frappe:developfrom
GursheenK:mail-sidebar-transparent-bg
Jun 28, 2026
Merged

fix(mail): sidebar background in mobile view#108
GursheenK merged 1 commit into
frappe:developfrom
GursheenK:mail-sidebar-transparent-bg

Conversation

@GursheenK

Copy link
Copy Markdown
Member

frappe-ui Sidebar is transparent in dark mode by design. It sits flush on surface-base and is set apart only by its border.

But mail's mobile view re-uses the same Sidebar as a fixed overlay over content, so the transparent background lets content show through. Since we add the overlay behavior, this fix forces an opaque bg-surface-base only on mobile, leaving desktop untouched.

If the design intent changes, this can move upstream to frappe-ui later. For now, keeping it in our app makes sense.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@GursheenK GursheenK marked this pull request as ready for review June 28, 2026 08:55
@greptile-apps

greptile-apps Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
frontend/src/apps/mail/components/AppSidebar.vue Adds a mobile-only opaque background class to the sidebar overlay.

Reviews (1): Last reviewed commit: "fix: opaque mobile sidebar background" | Re-trigger Greptile

@GursheenK

Copy link
Copy Markdown
Member Author

@krantheman merging this for now you can take a look and remove later if having mobile-specific classes in frappe ui sidebar makes more sense eventually

@GursheenK GursheenK merged commit 486ade7 into frappe:develop Jun 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant