fix(mail): sidebar background in mobile view#108
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| frontend/src/apps/mail/components/AppSidebar.vue | Adds a mobile-only opaque background class to the sidebar overlay. |
Reviews (1): Last reviewed commit: "fix: opaque mobile sidebar background" | Re-trigger Greptile
Member
Author
|
@krantheman merging this for now you can take a look and remove later if having mobile-specific classes in frappe ui sidebar makes more sense eventually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frappe-ui
Sidebaris transparent in dark mode by design. It sits flush onsurface-baseand is set apart only by its border.But mail's mobile view re-uses the same
Sidebaras a fixed overlay over content, so the transparent background lets content show through. Since we add the overlay behavior, this fix forces an opaquebg-surface-baseonly on mobile, leaving desktop untouched.If the design intent changes, this can move upstream to
frappe-uilater. For now, keeping it in our app makes sense.