Added timeout for the stall current of the D-Bug Speed Controller - #47
Open
frc3316 wants to merge 1 commit into
Open
Added timeout for the stall current of the D-Bug Speed Controller#47frc3316 wants to merge 1 commit into
frc3316 wants to merge 1 commit into
Conversation
| private double maxCurrent; // The high threshold for current control | ||
|
|
||
| private double stallTimeout; | ||
| private double stallInitTime = 0.0; // The FTGA time when the current turns to stall |
Collaborator
|
Code looks good. |
Collaborator
|
Also, Please refactor the code in the constructors to remove code duplication. Errors will appear because of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.