Skip to content

Fix Stage 1A solutions - #172

Open
Daniel1464 wants to merge 2 commits into
frcsoftware:mainfrom
Daniel1464:fix1ASolutions
Open

Fix Stage 1A solutions#172
Daniel1464 wants to merge 2 commits into
frcsoftware:mainfrom
Daniel1464:fix1ASolutions

Conversation

@Daniel1464

Copy link
Copy Markdown
Contributor

Description

Fixes Drivetrain Sim and Flywheel Sim being too slow in the CTRE solution (you need to feed in motorSim.getMotorVoltage(), not motor.getMotorVoltage(), since the former is the desired voltage and the latter is the voltage already applied).

Also, added some stuff:

  1. Units for flywheel sim position and velocity for both solutions(important since REV now uses radians while CTRE sticks with rotations)
  2. AdvantageScopeLayout.json for REV solution.
  3. NT key consistency between both solutions

Meta

Merge checklist:

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

🌐 Preview URL: https://pr-172.frcsoftware.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants