fix: align constrained INTEGER length encoding with decoder#13
Merged
Alonza0314 merged 1 commit intoMar 31, 2026
Merged
Conversation
Contributor
Author
|
@Alonza0314 Test all pass |
There was a problem hiding this comment.
Pull request overview
This PR fixes aligned PER constrained INTEGER length determinant encoding for value ranges greater than 65536 by aligning the encoder’s byte-length calculation with the decoder’s logic (issue #12), and adds regression tests to prevent reintroducing the mismatch.
Changes:
- Fix
appendIntegerbyte-length calculation forvalueRange > 65536by breaking only when the shifted range becomes zero. - Add regression tests covering two previously failing constrained ranges and validate both exact bytes and Marshal/Unmarshal round-trip.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| marshal.go | Adjusts constrained INTEGER length determinant byte-length calculation to match decoder behavior for large ranges. |
| aper_test.go | Adds regression tests verifying correct encoded bytes and successful round-trip decoding for affected ranges. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing