hwpmc: Promote hwpmc EXTERROR diagnostics#2180
Open
afscoelho wants to merge 1 commit into
Open
Conversation
|
Thank you for taking the time to contribute to FreeBSD! Some of files have special handling: Important @ngie-eign wants to review changes to tests |
afscoelho
changed the title
afscoelho
force-pushed
the
pr/pmc/hwpmc-exterr
branch
3 times, most recently
from
d81b7c5 to
34314c4
Compare
Contributor
Author
|
Hi @mashtizadeh / @mhorne, just a continuation of the first PR that introduced exterror. Thanks for your time |
Contributor
Author
mashtizadeh
suggested changes
May 15, 2026
Contributor
mashtizadeh
left a comment
mashtizadeh
left a comment
There was a problem hiding this comment.
Can you check the output for a DF counter with a reserved bit set? If it shows all those errors multiple times we have a problem then.
Add EXTERROR coverage for hwpmc_amd, hwpmc_ibs, hwpmc_mod user-visible validation paths. Add root-only ATF regression test for representative negative cases. Sponsored by: AMD Signed-off-by: Andre Silva <andasilv@amd.com>
afscoelho
force-pushed
the
pr/pmc/hwpmc-exterr
branch
from
34314c4 to
16b89cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi - this promotes the hwpmc extended-error work into upstream. Highlights:
hwpmc_exterr_test) that walks through the typical negative scenariosTesting
make -j${NCPU} buildworldmake -j${NCPU} buildkernel KERNCONF=${KERNCONF}kyua test -k /usr/tests/Kyuafile hwpmc_exterr_test