hwpmc: add AMD Zen3 IBS errata workarounds (1293, 1238, 1347)#2200
Open
afscoelho wants to merge 1 commit into
Open
hwpmc: add AMD Zen3 IBS errata workarounds (1293, 1238, 1347)#2200afscoelho wants to merge 1 commit into
afscoelho wants to merge 1 commit into
Conversation
afscoelho
force-pushed
the
pr/pmc/ibs-errata
branch
from
3659f88 to
24c2050
Compare
Contributor
Author
|
Hi @mashtizadeh / @mhorne, Thanks for your time |
Member
Contributor
Author
afscoelho
changed the title
Contributor
|
Again this is like that other patch, if the errata only causes bits to be questionable we should resolve this in the tools I that I showed you, not in the kernel. Otherwise, wIt’s going to become a spaghetti of attempts to clear bits. I didn’t handle any of them yet but with the new pmc tools you’ll be able to put them in one central place for post-processing. It also has the cpuids saved so you can almost verbatim copy this code into it at some point. |
freebsd#1347) Handle three Family 19h IBS errata in the consumer (pmcstat), keyed off the producer-side cpuid carried in PMCLOG_TYPE_INITIALIZE: - freebsd#1238 (<10h): suppress IbsIcMiss in pmcstat fetch decode -- the IBS_FETCH_CTL IcMiss bit reports bogus values on affected parts. - freebsd#1293 (00h-0Fh): mask the L2Miss and OpDcMissOpenMemReqs fields of IBS_OP_DATA3 in pmcstat op decode when DcMissNoMabAlloc or SwPf is set in the same sample -- those fields (and IBS_OP_DATA2, which pmcstat does not display) are invalid in that case. - freebsd#1347 (<10h): L1TLB page-size uses an alternate encoding; defer the decode and leave a comment for future post-processing tooling. Sanitization lives in pmcstat, not in hwpmc, so raw pmclog data is preserved for consumers that want to filter (or interpret) the errata differently. Sponsored by: AMD Signed-off-by: Andre Silva <andasilv@amd.com>
afscoelho
force-pushed
the
pr/pmc/ibs-errata
branch
from
24c2050 to
d2026a7
Compare
Contributor
Author
Hmm, ok same logic as #2143, I'll move the DATA2 zeroing and the two DATA3 bit clears into pmcstat_print_ibs_op next to the existing 1238 handling, drop the kernel hunk, and resubmmit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary