fix(ts): align projection_data naming#32
Merged
Conversation
- fix Cash capitalization bug in portfolio._allocateProportionally - align SimulationSettings default values with DEFAULT_SIMULATION_SETTINGS - unify projection_data/projection_df field name inconsistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:\n- Rename TypeScript core fields from projection_df to projection_data to match planner store + docs.\n- Update service/core model wiring and tests accordingly.\n- Align FIRECalculationService fallback defaults for income_minimum_factor/expense_minimum_factor with DEFAULT_SIMULATION_SETTINGS (0.1 / 0.5).\n\nNotes:\n- Potential breaking change only if external code depends on TS core properties named projection_df/detailed_projection_df; internal app uses projection_data.