ref: Conversion script path option #41
Open
FGBxRamel wants to merge 5 commits into
Open
Conversation
maurerle
approved these changes
Dec 2, 2025
Member
maurerle
left a comment
maurerle
left a comment
There was a problem hiding this comment.
Looks good!
Did not have time to test it yet
Contributor
Author
I only tested it with a single file as path, which works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional parameter to the conversion script, making it possible to only convert one picture (or another path), speeding up the process when you only need one. I outsourced the conversion into a function as I think it looks clearer that way.
I furthermore added exiftool to the dependencies.
The original plan was to also make the conversion concurrent, but I failed at doing so. Inkscape seems to not be a fan of more than one instance.