Relax crypton bounds and bump release versions - #270
Open
freizl wants to merge 4 commits into
Open
Conversation
freizl
force-pushed
the
fix/stackage-7929
branch
from
April 18, 2026 03:08
c1a88f8 to
9a806cb
Compare
|
This would help with commercialhaskell/stackage#7929 |
|
I am using this local hoauth2/hoauth2/stack.yaml file to build: (Though I guess Then following seems to work for me with Stackage Nightly: diff --git a/hoauth2/hoauth2.cabal b/hoauth2/hoauth2.cabal
index 4c215df..21d58e2 100644
--- a/hoauth2/hoauth2.cabal
+++ b/hoauth2/hoauth2.cabal
@@ -81,7 +81,7 @@ library
, exceptions >=0.8.3 && <0.11
, http-conduit >=2.1 && <2.4
, http-types >=0.11 && <0.13
- , memory ^>=0.18
+ , ram
, microlens >=0.4 && <0.6
, text >=2.0 && <2.3
, transformers >=0.4 && <0.7
diff --git a/hoauth2/src/Network/OAuth2/Experiment/Pkce.hs b/hoauth2/src/Network/OAuth2/Experiment/Pkce.hs
index 57351df..166eb5c 100644
--- a/hoauth2/src/Network/OAuth2/Experiment/Pkce.hs
+++ b/hoauth2/src/Network/OAuth2/Experiment/Pkce.hs
@@ -43,7 +43,7 @@ mkPkceParam = do
}
encodeCodeVerifier :: BS.ByteString -> Text
-encodeCodeVerifier = B64.extractBase64 . B64.encodeBase64Unpadded . BS.pack . ByteArray.unpack . hashSHA256
+encodeCodeVerifier = B64.extractBase64 . B64.encodeBase64Unpadded . hashSHA256
genCodeVerifier :: MonadIO m => m BS.ByteString
genCodeVerifier = liftIO $ getBytesInternal BS.empty
@@ -64,8 +64,9 @@ getBytesInternal ba
let bsUnreserved = ba `BS.append` BS.filter isUnreversed bs
getBytesInternal bsUnreserved
-hashSHA256 :: BS.ByteString -> H.Digest H.SHA256
-hashSHA256 = H.hash
+hashSHA256 :: BS.ByteString -> BS.ByteString
+hashSHA256 bs =
+ ByteArray.convert (H.hash bs :: H.Digest H.SHA256)
isUnreversed :: Word8 -> Bool
isUnreversed w = w `BS.elem` unreverseBSI have not tested it though. |
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cryptonupper bounds inhoauth2andhoauth2-providersto allow1.1.xcabal.projectindex-stateto a current Hackage statehoauth2-2.15.1andhoauth2-providers-0.9.1main; this is the actual fix on a feature branchContext
Stackage comment: commercialhaskell/stackage#7929 (comment)
That comment reports
hoauth2-2.15.0as out of bounds forcrypton-1.1.0because the package currently requiredcrypton <1.1.Validation
cabal updatecabal build hoauth2 hoauth2-providers --dry-run