Conversation
lmfaole
requested review from
Copilot,
fremtindelise,
kristianulv23,
piofinn and
zenabii
Collaborator
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/minor/number-input/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
fremtind-bot
added a commit
that referenced
this pull request
Apr 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Denne PR-en introduserer en ny NumberInput-komponent i @fremtind/jokul, basert på native input type="number" og med en valgfri stepper-variant (egne +/- knapper som bruker native stepping).
Changes:
- Lagt til ny
NumberInputReact-komponent med props, styles, Storybook-stories og dev-eksempel. - Lagt til en
stepper-modus som brukerstepUp/stepDownog trigger ReactonChangeviainput-event. - Lagt til unit/integrasjonstester (Vitest + Playwright) og snapshots, samt package exports og changeset.
Reviewed changes
Copilot reviewed 14 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/jokul/src/styles/styles.scss | Inkluderer NumberInput-styles i samlet styles-entry. |
| packages/jokul/src/components/number-input/types.ts | Definerer NumberInputProps inkl. stepper, align, width. |
| packages/jokul/src/components/number-input/styles/number-input.scss | Ny komponentstyling, inkl. invalid-state og stepper-layout. |
| packages/jokul/src/components/number-input/styles/_index.scss | Styles-entry med avhengigheter til button/text-input styles. |
| packages/jokul/src/components/number-input/stories/NumberInputExamples.stories.tsx | Storybook “skjembilde”-eksempel + play test. |
| packages/jokul/src/components/number-input/stories/NumberInput.stories.tsx | Storybook hovedstories (inkl. stepper og play tests). |
| packages/jokul/src/components/number-input/NumberInput.tsx | Implementasjon av NumberInput med optional stepper-knapper. |
| packages/jokul/src/components/number-input/NumberInput.test.tsx | Vitest unit/a11y tester for komponenten. |
| packages/jokul/src/components/number-input/integration/number-input.spec.ts | Playwright integrasjonstester for komponenten. |
| packages/jokul/src/components/number-input/integration/screenshots/renders-correctly-chromium-default.png | Ny/oppdatert snapshot (light, default). |
| packages/jokul/src/components/number-input/integration/screenshots/renders-correctly-chromium-default-dark.png | Ny/oppdatert snapshot (dark, default). |
| packages/jokul/src/components/number-input/integration/screenshots/renders-correctly-chromium-compact-light.png | Ny/oppdatert snapshot (light, compact). |
| packages/jokul/src/components/number-input/integration/screenshots/renders-correctly-chromium-compact-dark.png | Ny/oppdatert snapshot (dark, compact). |
| packages/jokul/src/components/number-input/integration/screenshots/renders-allthethings-correctly-chromium-compact-light.png | Ny/oppdatert snapshot (light, allthethings). |
| packages/jokul/src/components/number-input/integration/screenshots/renders-allthethings-correctly-chromium-compact-dark.png | Ny/oppdatert snapshot (dark, allthethings). |
| packages/jokul/src/components/number-input/index.ts | Ny public entry for subpath export. |
| packages/jokul/src/components/number-input/development/NumberInputExample.tsx | DevExample for lokal utvikling (knobs + summary). |
| packages/jokul/src/components/number-input/development/Example.tsx | Kobler NumberInput inn i dev-example runner. |
| packages/jokul/package.json | Legger til subpath exports for ./number-input og styles. |
| .changeset/little-moose-think.md | Changeset (minor) for ny komponent. |
lmfaole
force-pushed
the
minor/number-input
branch
from
677b966 to
f46270d
Compare
lmfaole
force-pushed
the
minor/number-input
branch
from
f46270d to
6ec2db4
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 9, 2026
Collaborator
|
Warning @lmfaole, Figma Code Connect feilet. Warning @lmfaole, Figma Code Connect feilet. |
fremtind-bot
added a commit
that referenced
this pull request
Apr 9, 2026
lmfaole
force-pushed
the
minor/number-input
branch
from
6ec2db4 to
c32e15d
Compare
lmfaole
force-pushed
the
minor/number-input
branch
from
c32e15d to
4db5c61
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 9, 2026
fremtind-bot
added a commit
that referenced
this pull request
Apr 9, 2026
lmfaole
force-pushed
the
minor/number-input
branch
from
4db5c61 to
6be441a
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 9, 2026
lmfaole
force-pushed
the
minor/number-input
branch
from
6be441a to
88056f6
Compare
lmfaole
force-pushed
the
minor/number-input
branch
2 times, most recently
from
e4f05fb to
c741551
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 16, 2026
fremtind-bot
added a commit
that referenced
this pull request
Apr 16, 2026
lmfaole
force-pushed
the
minor/number-input
branch
from
c741551 to
b5fc997
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 16, 2026
fremtindelise
approved these changes
Apr 16, 2026
lmfaole
force-pushed
the
minor/number-input
branch
from
b5fc997 to
2f6db45
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 16, 2026
lmfaole
force-pushed
the
minor/number-input
branch
from
2f6db45 to
c78efcc
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 16, 2026
lmfaole
force-pushed
the
minor/number-input
branch
from
c78efcc to
ac8b1b1
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 16, 2026
Legger til NumberInput, en skjemakomponent for numeriske verdier som bruker native input type="number" med Jøkul-styling og InputGroup-støtte. Komponenten støtter en stepper-variant med knapper på hver side av feltet for å øke og senke verdien med nettleserens native stepping, slik at min, max og step respekteres. Stepper-knappene deaktiveres automatisk når verdien når min eller max.
lmfaole
force-pushed
the
minor/number-input
branch
from
ac8b1b1 to
bdf5b5e
Compare
fremtind-bot
added a commit
that referenced
this pull request
Apr 16, 2026
kristianulv23
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 Endringer
NumberInputi Jøkul med støtte for nativeinput type="number"og valgfri stepper.data-testautoid,alignogwidth.Komponenter/NumberInput/Eksempler.🩹 Løser følgende issues