Merged
Conversation
lmfaole
changed the title
lmfaole
requested review from
fremtindelise,
kristianulv23,
piofinn and
zenabii
Collaborator
Kort utdrag av loggen |
Contributor
There was a problem hiding this comment.
Pull request overview
Denne PR-en forbedrer CI-opplevelsen rundt Figma Code Connect i pull request-workflowen, ved å trigge sjekken mer presist og gi bedre feildiagnostikk når valideringen feiler.
Changes:
- Introduserer et eget
figma_code_connectpaths-filter som bare kjører Figma Code Connect ved relevante endringer. - Legger til
figma:test:ci-script for mer CI-egnet kjøring (dry-run + strengere flagg). - Forbedrer feilmeldinger ved å samle loggutdrag i step summary og en egen sticky PR-kommentar, og fjerner kommentaren automatisk når feilen er borte.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/jokul/package.json | Legger til figma:test:ci for stabil CI-kjøring av Code Connect. |
| .github/workflows/pull_request.yml | Nytt filter for Code Connect, ny CI-run, og bedre/ryddigere feilsummering og PR-kommentering. |
lmfaole
force-pushed
the
minor/figma-code-connect-ci
branch
from
a11166b to
7ac28be
Compare
lmfaole
force-pushed
the
minor/figma-code-connect-ci
branch
from
1f33225 to
ae1a27b
Compare
- Eget paths-filter slik at sjekken bare kjøres ved relevante endringer - Nytt figma:test:ci-script med dry-run og strengere flagg - Loggutdrag i job summary og en sticky PR-kommentar med collapsable Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lmfaole
force-pushed
the
minor/figma-code-connect-ci
branch
from
542945b to
9566e98
Compare
kristianulv23
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hva er endret
Denne PR-en gjør Figma Code Connect-sjekken i CI mer presis og lettere å forstå når den feiler.
@fremtind/jokul.Hvorfor
I dag får vi i praksis bare beskjed om at Figma Code Connect feilet, uten særlig hjelp til å skjønne hvorfor. Målet med denne PR-en er å gjøre feilen mer konkret, så det blir enklere å se hva som må rettes.
Testet
pnpm run figma:test:cilokalt med gyldig token.Ikke en del av denne PR-en
Denne PR-en retter ikke de eksisterende avvikene mellom kode og Figma. Den forbedrer bare hvordan CI-en oppdager og forklarer dem.