Add Meter electrical component with transformer ratios support#440
Add Meter electrical component with transformer ratios support#440tiyash-basu-frequenz wants to merge 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull request overview
This PR adds support for electrical meters with transformer ratios to track current and voltage transformer configurations over time. The implementation introduces new protobuf messages for representing instrument transformers (CTs and VTs) used in metering applications.
Changes:
- Added
TransformerRatio,TransformerRatioThreePhase,MeterTransformerRatio, andMetermessages to support metering with instrument transformers - Updated
ElectricalComponentCategorySpecificInfoto include the newMetercomponent category - Updated release notes to document the new messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto | Adds four new messages for meter transformer ratios and updates ElectricalComponentCategorySpecificInfo oneof to include Meter |
| RELEASE_NOTES.md | Documents the new messages and updates to ElectricalComponentCategorySpecificInfo |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto
Outdated
Show resolved
Hide resolved
proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto
Show resolved
Hide resolved
proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto
Outdated
Show resolved
Hide resolved
tiyash-basu-frequenz
force-pushed
the
meter_ratios
branch
2 times, most recently
from
a815d54 to
b3bfab0
Compare
The following new messages have been added: - `TransformerRatio`: Represents a single transformer ratio with primary and secondary values. - `TransformerRatioThreePhase`: Represents a three-phase transformer ratio, containing individual `TransformerRatio` messages for each phase. - `MeterTransformerRatio`: Represents a meter's transformer ratio (either CT or VT) along with its operational lifetime. - `Meter`: Represents a meter with lists of current and voltage transformer ratios. Each list contains `MeterTransformerRatio` entries to allow tracking historical configurations. Additionally, the `ElectricalComponentCategorySpecificInfo` message has been updated to include the new `Meter` component category. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
tiyash-basu-frequenz
force-pushed
the
meter_ratios
branch
from
b3bfab0 to
2f9140b
Compare
| message TransformerRatioThreePhase { | ||
| // The transformer ratio for phase 1 (L1/A/R). | ||
| TransformerRatio phase_1 = 1; | ||
|
|
||
| // The transformer ratio for phase 2 (L2/B/Y). | ||
| TransformerRatio phase_2 = 2; | ||
|
|
||
| // The transformer ratio for phase 3 (L3/C/B). | ||
| TransformerRatio phase_3 = 3; | ||
| } |
There was a problem hiding this comment.
I am not sure about this struct, so some input would be nice.
The reason I am not sure about this is that I do not know of a practical scenario in which the transformer ratios will be different for each phase. In theory, this could happen if someone decides to measure just different single-phase lines using the same meter (say to save costs) or electricians had to use a different transformer due to them running out of the standard kind. But how likely is this to happen, and if we need to support these edge cases?
My gut says we need to support these edge cases, but I could be over-engineering here.
tiyash-basu-frequenz
added
the
status:blocked
|
I am marking it blocked and draft to prevent accidental merges, since we realized we need t align on the requirements here. |
1 participant
The following new messages have been added:
TransformerRatio: Represents a single transformer ratio with primary and secondary values.TransformerRatioThreePhase: Represents a three-phase transformer ratio, containing individualTransformerRatiomessages for each phase.MeterTransformerRatio: Represents a meter's transformer ratio (either CT or VT) along with its operational lifetime.Meter: Represents a meter with lists of current and voltage transformer ratios. Each list containsMeterTransformerRatioentries to allow tracking historical configurations.Additionally, the
ElectricalComponentCategorySpecificInfomessage has been updated to include the newMetercomponent category.