Switch to MicrogridConfig from fz-gridpool #216
Merged
Merged
Conversation
github-actions
Bot
added
part:tests
To avoid conflicts with fz-gridpool dependency. Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
This will replace the `MicrogridConfig` class from `frequenz.data`. Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
And remove local version. Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the MicrogridConfig class from the local frequenz.data.microgrid.config module to the external frequenz-gridpool package, following its prior migration in frequenz-gridpool-python#18.
Key changes:
- Added
frequenz-gridpool >= 0.1, < 0.2dependency - Updated imports across all files to use
from frequenz.gridpool import MicrogridConfig - Removed local
config.pymodule and its associated tests
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added frequenz-gridpool dependency and bumped typing-extensions version |
| src/frequenz/data/microgrid/init.py | Updated import to use frequenz.gridpool package |
| src/frequenz/data/microgrid/component_data.py | Updated import to use frequenz.gridpool package |
| src/frequenz/data/microgrid/config.py | Removed entire file as functionality moved to external package |
| src/frequenz/lib/notebooks/reporting/data_processing.py | Updated import to use frequenz.gridpool package |
| src/frequenz/lib/notebooks/reporting/utils/helpers.py | Updated import to use frequenz.gridpool package |
| tests/test_config.py | Removed tests for the config module (now maintained in frequenz-gridpool) |
| tests/test_helpers.py | Updated import to use frequenz.gridpool package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mohammad-Tayyab-Frequenz
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the
MicrogridConfigfromfrequenz.data.microgridwith the one from thefrequenz-gridpoolpackage.The class was previously migrated in frequenz-floss/frequenz-gridpool-python#18