Skip to content

Add tests for steam boilers#71

Merged
simonvoelcker merged 1 commit into
frequenz-floss:v0.x.xfrom
simonvoelcker:add-steam-boiler
May 12, 2026
Merged

Add tests for steam boilers#71
simonvoelcker merged 1 commit into
frequenz-floss:v0.x.xfrom
simonvoelcker:add-steam-boiler

Conversation

@simonvoelcker
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests labels May 7, 2026
@simonvoelcker simonvoelcker self-assigned this May 7, 2026
@simonvoelcker simonvoelcker marked this pull request as ready for review May 8, 2026 11:36
@simonvoelcker simonvoelcker requested a review from a team as a code owner May 8, 2026 11:36
@simonvoelcker simonvoelcker requested review from florian-wagner-frequenz and shsms and removed request for a team May 8, 2026 11:36
Copy link
Copy Markdown
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will leave for @shsms to approve.

@simonvoelcker simonvoelcker force-pushed the add-steam-boiler branch 3 times, most recently from 5fb2f48 to 592b781 Compare May 11, 2026 15:03
@simonvoelcker simonvoelcker added the cmd:skip-release-notes It is not necessary to update release notes for this PR label May 11, 2026
@simonvoelcker simonvoelcker changed the title Add steam boiler Add more tests for steam boilers May 11, 2026
Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>
@simonvoelcker simonvoelcker changed the title Add more tests for steam boilers Add tests for steam boilers May 11, 2026
@llucax
Copy link
Copy Markdown
Contributor

llucax commented May 12, 2026

@codex Please do an exhaustive review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :P

@simonvoelcker simonvoelcker added this pull request to the merge queue May 12, 2026
Merged via the queue into frequenz-floss:v0.x.x with commit 307f473 May 12, 2026
8 checks passed
@simonvoelcker simonvoelcker deleted the add-steam-boiler branch May 12, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants