Remove python package and pyo3#87
Conversation
Signed-off-by: Phillip Wenig <phillip.wenig@frequenz.com>
|
Delay merging until frequenz-floss/frequenz-resampling-python#17 is merged. |
There was a problem hiding this comment.
Pull request overview
This PR removes the in-repo Python package (PyO3 bindings, stubs, tests, and Python tooling/docs) so the repository focuses on shipping and documenting the Rust crate, and directs Python users to the dedicated frequenz-resampling-python repository.
Changes:
- Removed PyO3 bindings and all Python package/test/tooling infrastructure (pyproject, nox, mkdocs, Python CI).
- Updated crate configuration to drop the
pythonfeature andpyo3dependency. - Updated README and release notes with upgrade guidance for Python users.
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_resampler.py |
Removed Python binding tests. |
tests/__init__.py |
Removed Python tests package marker. |
src/python.rs |
Removed PyO3 module implementation. |
src/lib.rs |
Removed conditional python module inclusion. |
pyproject.toml |
Removed Python packaging/build/test configuration. |
noxfile.py |
Removed nox-based Python automation. |
mkdocs.yml |
Removed MkDocs site configuration for Python docs. |
frequenz/resampling/_rust_backend.pyi |
Removed Python typing stubs for the Rust backend module. |
frequenz/resampling/__init__.py |
Removed Python package entrypoint exports. |
docs/reference.md |
Removed Python API reference page. |
docs/index.md |
Removed docs index that embedded README. |
docs/_scripts/mkdocstrings_autoapi.py |
Removed mkdocstrings auto-API generation script. |
docs/_overrides/main.html |
Removed MkDocs theme override. |
docs/_css/style.css |
Removed docs site custom styling. |
docs/_css/mkdocstrings.css |
Removed mkdocstrings CSS customization. |
docs/SUMMARY.md |
Removed MkDocs navigation summary. |
RELEASE_NOTES.md |
Added upgrade note pointing Python users to the new repo; reset to template-style sections. |
README.md |
Removed Python usage docs; added pointer to the dedicated Python repository. |
Cargo.toml |
Removed python feature, pyo3 dependency, and cdylib crate-type used for bindings. |
.github/workflows/rust-ci.yaml |
Removed PR/push Rust CI workflow. |
.github/workflows/repo-config-migration.yaml |
Removed repo-config migration workflow. |
.github/workflows/python-ci-pr.yaml |
Removed Python CI workflow. |
.github/dependabot.yml |
Removed pip ecosystem updates; kept GitHub Actions and Cargo updates. |
Comments suppressed due to low confidence (1)
.github/workflows/rust-ci.yaml:1
- Removing this workflow leaves the repository without any Rust test/build CI on pull_request/push events (the remaining workflow runs
cargo testonly on tag pushes). Please keep or replace this with an equivalent Rust CI workflow to ensure PRs are validated before merge.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Some of the workflows are still python related and therefore do not start/finish. We might need to bypass rules for this one. |
12e92db
into
frequenz-floss:v0.x.x
There was a problem hiding this comment.
Don't we still want this here? 😱
There was a problem hiding this comment.
Oops, yes, good you caught it. Also, mysterious, that I can't find the rust release ci file.
There was a problem hiding this comment.
oh never mind, that's there, so we just need to add this file back. @phillip-wenig-frequenz
Summary