Skip to content

fix: warn when CSP nonce is missing despite useNonce config #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SisyphusZheng wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: warn when CSP nonce is missing despite useNonce config #3863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/fresh/src/middlewares/csp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@
return d;
});
} else {
console.warn(

Check failure on line 132 in packages/fresh/src/middlewares/csp.ts

View workflow job for this annotation

GitHub Actions / test (v2.x, ubuntu-latest) 

`console` usage is not allowed.
"CSP nonce not found on response. Did you use ctx.render() or a non-render response method like ctx.html()?",
);
directives = merged;
}

Expand Down
Loading