-
Notifications
You must be signed in to change notification settings - Fork 16
Completed homework. #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| // Import HTMLElement here | ||
| import HTMLElements from './HTMLElement'; | ||
|
|
||
| // Define class here | ||
|
|
||
| class DivElement extends HTMLElements { | ||
| constructor(content) { | ||
| super(content); | ||
| this.content = content; | ||
| this.tag = 'div'; | ||
| } | ||
| } | ||
| // Export class here | ||
| export default DivElement; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,13 @@ | ||
| // Define class here | ||
| class HTMLElement { | ||
| constructor(tag, content) { | ||
| this.tag = tag; | ||
| this.content = content; | ||
| } | ||
|
|
||
| render() { | ||
| return (`<${this.tag}>${this.content}</${this.tag}>`); | ||
| } | ||
| } | ||
| // Export class here | ||
| export default {}; | ||
| export default HTMLElement; |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,11 +1,17 @@ | ||||||
| import people from './people.json'; | ||||||
|
|
||||||
| people.forEach(function (person) { | ||||||
| people.forEach((person) => { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| const names = person.name.split(' '); | ||||||
| const firstName = names[0]; | ||||||
| const lastName = names[1]; | ||||||
| const email = person.email; | ||||||
| const phone = person.phone; | ||||||
| // const firstName = names[0]; | ||||||
| // const lastName = names[1]; | ||||||
| const [firstName, lastName] = names; | ||||||
| // const email = person.email; | ||||||
| // const phone = person.phone; | ||||||
| const { email, phone } = person; | ||||||
|
|
||||||
| console.log('First name: ' + firstName + '\nLast name: ' + lastName + '\nEmail: ' + email + '\nPhone number: ' + phone + '\n'); | ||||||
|
|
||||||
| console.log(`First name: ${firstName} Last name: ${lastName} | ||||||
| Email: ${email} | ||||||
| Phone number: ${phone} | ||||||
| `); | ||||||
| }); | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,16 @@ | ||
| function Timer(seconds) { | ||
| this.seconds = seconds; | ||
| // function Timer(seconds) { | ||
| // this.seconds = seconds; | ||
| // } | ||
|
|
||
| class Timer { | ||
| constructor(seconds) { | ||
| this.seconds = seconds; | ||
| } | ||
| } | ||
|
|
||
| Timer.prototype.start = function () { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be moved into the |
||
| var instance = this; | ||
| var timerInterval = setInterval(function () { | ||
| const instance = this; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once in constructor, you can drop this line |
||
| const timerInterval = setInterval(() => { | ||
| if (instance.seconds === 0) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And reference |
||
| clearInterval(timerInterval); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you don't need lines 8 or 9