Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/DivElement.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
// Import HTMLElement here
import HTMLElements from './HTMLElement';

// Define class here

class DivElement extends HTMLElements {
constructor(content) {
super(content);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
super(content);
super('div', content);

Then you don't need lines 8 or 9

this.content = content;
this.tag = 'div';
}
}
// Export class here
export default DivElement;
11 changes: 10 additions & 1 deletion src/components/HTMLElement.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
// Define class here
class HTMLElement {
constructor(tag, content) {
this.tag = tag;
this.content = content;
}

render() {
return (`<${this.tag}>${this.content}</${this.tag}>`);
}
}
// Export class here
export default {};
export default HTMLElement;
18 changes: 12 additions & 6 deletions src/rolodex/rolodexPrinter.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
import people from './people.json';

people.forEach(function (person) {
people.forEach((person) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
people.forEach((person) => {
people.forEach(({ name, email, phone }) => {

const names = person.name.split(' ');
const firstName = names[0];
const lastName = names[1];
const email = person.email;
const phone = person.phone;
// const firstName = names[0];
// const lastName = names[1];
const [firstName, lastName] = names;
// const email = person.email;
// const phone = person.phone;
const { email, phone } = person;

console.log('First name: ' + firstName + '\nLast name: ' + lastName + '\nEmail: ' + email + '\nPhone number: ' + phone + '\n');

console.log(`First name: ${firstName} Last name: ${lastName}
Email: ${email}
Phone number: ${phone}
`);
});
14 changes: 10 additions & 4 deletions src/timer/Timer.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
function Timer(seconds) {
this.seconds = seconds;
// function Timer(seconds) {
// this.seconds = seconds;
// }

class Timer {
constructor(seconds) {
this.seconds = seconds;
}
}

Timer.prototype.start = function () {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved into the Timer constructor.

var instance = this;
var timerInterval = setInterval(function () {
const instance = this;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once in constructor, you can drop this line

const timerInterval = setInterval(() => {
if (instance.seconds === 0) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And reference this.seconds here.

clearInterval(timerInterval);
}
Expand Down