Skip to content

Lynne Cooney Week 1 Assignment#5

Open
ilynne wants to merge 2 commits into
frontend-application-development-uw20:masterfrom
ilynne:develop
Open

Lynne Cooney Week 1 Assignment#5
ilynne wants to merge 2 commits into
frontend-application-development-uw20:masterfrom
ilynne:develop

Conversation

@ilynne
Copy link
Copy Markdown

@ilynne ilynne commented Apr 11, 2020

Week 1 HW Submission

Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.

  • Comfort rating on this assignment (1-5): 4
  • Completion rating on this assignment: complete


class DivElement extends HTMLElement {
constructor(content) {
super('div', content);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

const phone = person.phone;

console.log('First name: ' + firstName + '\nLast name: ' + lastName + '\nEmail: ' + email + '\nPhone number: ' + phone + '\n');
people.forEach((element) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
people.forEach((element) => {
people.forEach(({ name, email, phone }) => {

Comment thread src/timer/Timer.js
}, 1000);
};
start() {
const timerInterval = setInterval(() => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants