Completed homework.#11
Open
dgallinger wants to merge 1 commit into
Open
Conversation
t1mwillis
reviewed
May 27, 2020
|
|
||
| function App() { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
I don't think you need the fragments if there is one parent component.
t1mwillis
reviewed
May 27, 2020
|
|
||
| render () { | ||
| return ( | ||
| this.props.propertyData.map((property, i) => { |
t1mwillis
reviewed
May 27, 2020
| <div className="image"> | ||
| <img src={property.image} alt="" height='250' width='400'/> | ||
| </div> | ||
| <div className="location">{property.location.city},{' '} |
There was a problem hiding this comment.
Suggested change
| <div className="location">{property.location.city},{' '} | |
| <div className="location">{[property.location.city, property.location.country].join(', ') |
t1mwillis
reviewed
May 27, 2020
| {property.location.country} | ||
| </div> | ||
| <div className="description">{property.houseType}</div> | ||
| <div className="rating">{property.rating.stars}\5{' '}Stars |
There was a problem hiding this comment.
I would just use string interpolation instead of dropping in these spaces.
Suggested change
| <div className="rating">{property.rating.stars}\5{' '}Stars | |
| <div className="rating">`${property.rating.stars}\5 Stars` |
t1mwillis
reviewed
May 27, 2020
| totalCost: this.state.totalCost + parseInt(cost) | ||
| }) | ||
| } else { | ||
| alert('Property already in cart.'); |
t1mwillis
reviewed
May 27, 2020
| super(props); | ||
| this.state = { | ||
| infoArray: [], | ||
| costArray: [], |
There was a problem hiding this comment.
Do these need to be separate arrays? Can you maintain an array of objects and then use Array.map?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 3 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.
Comfort Rating 3
Complete