Skip to content

Sven Otto - Week 5 complete#1

Open
Bl4ckH4wkGER wants to merge 5 commits into
frontend-application-development-uw20:masterfrom
Bl4ckH4wkGER:master
Open

Sven Otto - Week 5 complete#1
Bl4ckH4wkGER wants to merge 5 commits into
frontend-application-development-uw20:masterfrom
Bl4ckH4wkGER:master

Conversation

@Bl4ckH4wkGER
Copy link
Copy Markdown

Week 5 HW Submission

Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.

  • Comfort rating on this assignment (1-5): 4 (issues primarily API and load/ error feedback related)
  • Completion rating on this assignment: complete (tried some of the bonus stuff, API caused me some troubles here and there)

Comment thread pokemon-api/src/Items.js

export default class Items extends React.Component {
state = {
isLoading: false,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread pokemon-api/src/Items.js
<div>
<h1>Search for Pokemon Items</h1>
<form onSubmit={this.searchForItem}>
<input type="text" value={this.state.searchInput} placeholder={'master-ball'} onChange={this.onInputChange} />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<input type="text" value={this.state.searchInput} placeholder={'master-ball'} onChange={this.onInputChange} />
<input type="text" value={this.state.searchInput} placeholder="master-ball" onChange={this.onInputChange} />

No need to wrap this in braces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants