Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion marko/md_renderer.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ def render_list(self, element: block.List) -> str:
with self.container(f"{element.bullet} ", " "):
result.append(self.render(child))
self._prefix = self._second_prefix
return "".join(result)
sep = "\n" if not element.tight else ""
return sep.join(result)

def render_list_item(self, element: block.ListItem) -> str:
return self.render_children(element)
Expand Down
17 changes: 17 additions & 0 deletions tests/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,23 @@ def test_markdown_renderer(self):
marko.convert(text)
)

def test_markdown_renderer_loose_list(self):
# A loose list (items separated by blank lines) must round-trip unchanged.
# Before the fix, render_list() emitted tight spacing regardless of
# element.tight, converting the loose list to a tight list and producing
# different HTML output.
for text in (
"- item1\n\n- item2\n",
"- a\n\n- b\n\n- c\n",
"1. first\n\n2. second\n",
):
markdown = marko.Markdown(renderer=MarkdownRenderer)
rerendered = markdown(text)
assert rerendered == text, f"loose list not preserved: {text!r} -> {rerendered!r}"
assert normalize_html(marko.convert(rerendered)) == normalize_html(
marko.convert(text)
)

def test_markdown_renderer_preserve_link_refs(self):
text = textwrap.dedent(
"""\
Expand Down