build: Boost.Asio handler-invoke compat shim (conan 1.90 vs legacy system Boost 1.83)#641
Merged
Merged
Conversation
… system Boost conan pins Boost 1.90, which removed boost/asio/detail/handler_invoke_helpers.hpp and the boost_asio_handler_invoke_helpers namespace. On build hosts carrying a legacy system Boost (e.g. libboost-dev 1.83 under /usr/include), that trees
Windows/MSVC has no legacy system Boost under /usr/include to leak boost/asio/impl/system_executor.hpp, so it never needs the shim and cannot resolve the relative force-include path (C1083). Wrap the add_compile_options in if(NOT MSVC); Linux/macOS keep the proven fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
Master is RED: every coin's
corefails buildingaddr_store.cppon the self-hosted runner (VM905) with:Root cause is a mixed-Boost include collision, not a code regression:
BOOST_VERSION 109000), which removedboost/asio/detail/handler_invoke_helpers.hppand theboost_asio_handler_invoke_helpersnamespace (theasio_handler_invokehooks were deprecated in 1.79, dropped since)./usr/include. Itsboost/asio/impl/system_executor.hppleaks onto the include path and still callsboost_asio_handler_invoke_helpers::invoke(...), which the conan (>= 1.90) tree no longer declares.The include chain from the failing TU: conan
boost/asio/system_executor.hpp:714-> system/usr/include/boost/asio/impl/system_executor.hpp. AnycoreTU that pulls asio hits it, so it is latent across all five coins and re-fires on every ccache eviction.Fix
core/boost_asio_compat.hppsupplies the namespace's historical default hook-freeinvoke(copy the function, call it) — identical to how Boost >= 1.90 dispatches internally. It is force-included ahead of every C++ TU via aCOMPILE_LANGUAGE:CXX-gatedadd_compile_optionsin the top-levelCMakeLists.txt, so all coins survive cache eviction. Guarded onBOOST_VERSION >= 108400and claims Boost's own include guard, so it is inert on any Boost that still ships the namespace.Build compat only — no behaviour change. c2pool defines no
asio_handler_invokeoverloads (verified), so the hook-free default is behaviourally equivalent.Durable follow-up (infra, not this PR)
The lasting cleanup is removing the stray system
libboost-dev1.83 from VM905 so the conan pin is the only Boost the build sees. This shim is the cache-eviction-proof safety net requested regardless.Signed, attribution-clean. Merge-gated — holding for push-approval per Rule 12.