Add connection-scoped query resolution - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds core support for
connection_queriesconfig parsing and query resolution.connection_queriesconfig support.connection_queries.<connection>.<query_name>queries.<query_name>@file.sqlhandlingVerification
.venv/bin/pytest tests/test_sql2json.py::test_run_query_by_name_uses_connection_scoped_query tests/test_sql2json.py::test_run_query_by_name_falls_back_to_global_query tests/test_sql2json.py::test_run_query_by_name_scoped_query_takes_precedence_over_global tests/test_sql2json.py::test_run_query_by_name_rejects_malformed_connection_queries tests/test_sql2json.py::test_run_query_by_name_rejects_connection_queries_for_unknown_connection tests/test_cli.py::TestErrorOutput::test_malformed_connection_queries_stderr_is_json— 6 passed.venv/bin/pytest— 133 passed, 12 deselected.venv/bin/black --check sql2json tests— 16 files would be left unchanged.venv/bin/flake8 sql2json tests— passed.venv/bin/mypy sql2json— Success: no issues found in 5 source files