Add support for deserialization of owned values#16
Closed
nklhtv wants to merge 6 commits into
Closed
Conversation
This was referenced Sep 13, 2022
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
I've integrated the additional fixes into my PR by cherry-picking your commits!
| use std::{error, io, fmt}; | ||
| use serde::de::{Visitor}; | ||
| use serde::export::{PhantomData}; | ||
| use serde::__private::{PhantomData}; |
There was a problem hiding this comment.
Well, we should really be importing this from std, haha.
| pub use config::*; | ||
| pub use types::{Error, ParseHexError}; | ||
|
|
||
| use serde::__private::PhantomData; |
There was a problem hiding this comment.
Invasive things like cargo fmt are likely better left to individual PRs, just adds unnecessary noise to the diff and thus work to the reviewers.
Author
There was a problem hiding this comment.
@thomaseizinger I agree with you, and i reverted the code reformat commit
This reverts commit fb02c8f.
Author
|
Closed in favor of #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #8 but includes: