Upgrade to .NET 10 and fix project configuration issues#87
Open
fszymaniak wants to merge 7 commits intomainfrom
Open
Upgrade to .NET 10 and fix project configuration issues#87fszymaniak wants to merge 7 commits intomainfrom
fszymaniak wants to merge 7 commits intomainfrom
Conversation
The .NET 10 upgrade broke the CI pipeline because:
- NuGet packages (Microsoft.AspNetCore.OpenApi 9.0.6, etc.) are
incompatible with net10.0 target framework
- Solution file had 5 project GUIDs replaced with duplicate zeros
({00000000-...}), causing MSBuild to fail to build those projects
- Build configuration entries were removed for most test projects
This reverts all projects back to net9.0, restores the solution file
with unique valid GUIDs, reverts unit test SDKs from Web back to
standard, and fixes the Stryker target-framework reference.
https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu
…ions Update all NuGet packages to .NET 10 compatible versions: - Microsoft.AspNetCore.OpenApi: 9.0.6 -> 10.0.3 - Swashbuckle.AspNetCore: 9.0.3 -> 10.1.2 - Swashbuckle.AspNetCore.Annotations: 9.0.3 -> 10.1.2 - Microsoft.NET.Test.Sdk: 17.12.0 -> 18.0.1 - Microsoft.AspNetCore.Mvc.Testing: 9.0.11 -> 10.0.2 - Microsoft.Extensions.Hosting.Abstractions: 9.0.11 -> 10.0.3 - Microsoft.Extensions.Options: 9.0.11 -> 10.0.2 Also update Dockerfile base images to .NET 10.0 and add missing Common.Tests.Unit COPY line. https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu
Fixes NU1605 package downgrade error: Hosting.Abstractions 10.0.3 transitively requires Options >= 10.0.3, but it was pinned at 10.0.2. https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu
In Microsoft.OpenApi v2.0 (pulled in by Swashbuckle 10.x), types like OpenApiInfo moved from Microsoft.OpenApi.Models to Microsoft.OpenApi. https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- RSPEC-6968: Add return types to ProducesResponseType attributes on all HealthController endpoints and Level1 SeasonsController - RSPEC-1192: Extract "Healthy" string literal to constant in HealthCheckService, extract "/api/v3/seasons" to SeasonsBasePath constant in Level3 EpisodesController - RSPEC-1118: Add protected constructor to Program class (utility class) https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu
The HealthyStatus constant was self-referencing (HealthyStatus = HealthyStatus) instead of being assigned the string literal "Healthy". https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu
- RSPEC-2701: Replace Assert.Equal(true, ...) with Assert.True() in HealthCheckServiceTests - RSPEC-2925: Replace Thread.Sleep with async Task.Delay in HealthCheckServiceTests - RSPEC-6968: Add typed ProducesResponseType to Level0/OfficeApiController and Level1/EpisodesController - RSPEC-3776: Reduce cognitive complexity in Program.cs by extracting DetermineBindingUrl and ConfigureBasicServices - RSPEC-1075/RSPEC-5332: Extract hardcoded URIs to helper method with NOSONAR comments https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the project to .NET 10 and resolves several configuration issues in the solution file and project files.
Key Changes
Microsoft.NET.Sdk.WebtoMicrosoft.NET.Sdkfor:Notable Details
https://claude.ai/code/session_01RNJdS4XPdZN1uFQiYvrCXu